Skip to contentSkip to conversation

Power-on monitor for phosphor-hwmon question

DISCUSSION Ivan Li11 3 participants 12 messages Oct 18, 2019 – Dec 2, 2019

lore
Share & tools
lore

Ivan Li11

author
#0 lore raw

Hi Team,

We found that there's no power-on monitor mechanism in phosphor-hwmon.
https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state. Is there any plan to implement it? Or other repository we can refer to ?

Thanks,
Ivan

author
#1 lore raw

Hi Team,

Does anyone have suggestion for this ?

Thanks your great support in advance.
From: openbmc <[email protected]> On Behalf Of Ivan Li11
Sent: Friday, October 18, 2019 5:59 PM
To: [email protected]
Subject: [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in phosphor-hwmon.
https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state. Is there any plan to implement it? Or other repository we can refer to ?

Thanks,
Ivan

#2 lore raw
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

Quoted 21 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]> *On Behalf Of *Ivan Li11 *Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there’s no power-on monitor mechanism in phosphor-hwmon.

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by ‘sel-logger’ when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

#3 lore raw
Quoted 13 lines · Matt Spinler
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 6 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

It should force you to switch 100%, but you would at least have to run both.

Here's what dbus-sensors does:

https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307a59e4b1cf86b8a6/src/Utils.cpp#L141

Basically just a dbus-match that sets a "powerStatusOn" bool that can be queried. Depending on the sensor type thresholds don't get crossed if that bool is set. We also have a similar bool for bios post, as some sensors come up later after power on.

Quoted 23 lines
Quoted 22 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]> *On Behalf Of *Ivan Li11 *Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there’s no power-on monitor mechanism in phosphor-hwmon.

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by ‘sel-logger’ when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

author
#4 lore raw
Quoted 33 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Tuesday, October 22, 2019 11:51 PM
To: Matt Spinler <[email protected]>; Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 13 lines · Matt Spinler
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 7 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

It should force you to switch 100%, but you would at least have to run both.

Here's what dbus-sensors does:

Quoted 8 lines

https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307
a59e4b1cf86b8a6/src/Utils.cpp#L141

Basically just a dbus-match that sets a "powerStatusOn" bool that can be queried. Depending on the sensor type thresholds don't get crossed if that bool is set. We also have a similar bool for bios post, as some sensors come up later after power on.

I try to use dbus-sensors and set "powerStatusOn" bool, but still have incorrect threshold logs during power on(S0) to power off(S5) state. Could you help to comment on it ?

Quoted 27 lines
Quoted 4 lines
Quoted 4 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]>

*On

Quoted 8 lines
Quoted 8 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 13 lines
Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

#5 lore raw
Quoted 36 lines · On 11/5/19 11:25 PM, Ivan Li11 wrote:
Quoted 36 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Tuesday, October 22, 2019 11:51 PM
To: Matt Spinler <[email protected]>; Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 13 lines · Matt Spinler
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 7 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

It should force you to switch 100%, but you would at least have to run both.

Here's what dbus-sensors does:

https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307
a59e4b1cf86b8a6/src/Utils.cpp#L141

Quoted 9 lines
Quoted 5 lines

Basically just a dbus-match that sets a "powerStatusOn" bool that can be queried. Depending on the sensor type thresholds don't get crossed if that bool is set. We also have a similar bool for bios post, as some sensors come up later after power on.

I try to use dbus-sensors and set "powerStatusOn" bool, but still have incorrect threshold logs during power on(S0) to power off(S5) state. Could you help to comment on it ?

This has only been tested with x86-power-control, are you using that project for power control or something else?

Quoted 27 lines
Quoted 27 lines
Quoted 4 lines
Quoted 4 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]>

*On

Quoted 8 lines
Quoted 8 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 13 lines
Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

author
#6 lore raw
Quoted 52 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Thursday, November 7, 2019 7:39 AM
To: Ivan Li11 <[email protected]>; Matt Spinler <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 29 lines · On 11/5/19 11:25 PM, Ivan Li11 wrote:
Quoted 29 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Tuesday, October 22, 2019 11:51 PM
To: Matt Spinler <[email protected]>; Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 20 lines · Matt Spinler
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

Quoted 5 lines
Quoted 5 lines

It should force you to switch 100%, but you would at least have to run both.

Here's what dbus-sensors does:

https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f6955827330

Quoted 9 lines
Quoted 8 lines

7
a59e4b1cf86b8a6/src/Utils.cpp#L141

Basically just a dbus-match that sets a "powerStatusOn" bool that can be queried. Depending on the sensor type thresholds don't get crossed if that bool is set. We also have a similar bool for bios post, as some sensors come up later after power on.

Quoted 8 lines
Quoted 1 line

I try to use dbus-sensors and set "powerStatusOn" bool, but still have

incorrect threshold logs during power on(S0) to power off(S5) state.

Quoted 2 lines

Could you help to comment on it ?

This has only been tested with x86-power-control, are you using that project for power control or something else?

Got it. I currently use phosphor-state-manager for power control.

Quoted 28 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Thanks your great support in advance.

*From:*openbmc

<[email protected]>

Quoted 23 lines
Quoted 23 lines

*On

Quoted 8 lines
Quoted 8 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 13 lines
Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

author
#7 lore raw
In reply to James Feist
Quoted 64 lines

-----Original Message-----
From: Ivan Li11
Sent: Thursday, November 7, 2019 4:35 PM
To: 'James Feist' <[email protected]>; Matt Spinler <[email protected]>; [email protected]
Subject: RE: [External] Power-on monitor for phosphor-hwmon question

Quoted 7 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Thursday, November 7, 2019 7:39 AM
To: Ivan Li11 <[email protected]>; Matt Spinler <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 32 lines
Quoted 31 lines · On 11/5/19 11:25 PM, Ivan Li11 wrote:
Quoted 31 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Tuesday, October 22, 2019 11:51 PM
To: Matt Spinler <[email protected]>; Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 13 lines · Matt Spinler
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 7 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

It should force you to switch 100%, but you would at least have to run

both.

Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

Here's what dbus-sensors does:

https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f6955827330

Quoted 11 lines
Quoted 8 lines

7
a59e4b1cf86b8a6/src/Utils.cpp#L141

Basically just a dbus-match that sets a "powerStatusOn" bool that can be queried. Depending on the sensor type thresholds don't get crossed if that bool is set. We also have a similar bool for bios post, as some sensors come up later after power on.

I try to use dbus-sensors and set "powerStatusOn" bool, but still have

incorrect threshold logs during power on(S0) to power off(S5) state.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Could you help to comment on it ?

This has only been tested with x86-power-control, are you using that project for power control or something else?

Got it. I currently use phosphor-state-manager for power control.

Hi James,
It seems that x86-power-control need POWER_BUTTON and POWER_OUT to be connected to GPIOE0/E1 or GPIOE2/E3 for passthrough. If our HW design doesn't follow it, x86-power-control will not work, right ?

Quoted 30 lines
Quoted 30 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Thanks your great support in advance.

*From:*openbmc

<[email protected]>

Quoted 24 lines
Quoted 24 lines

*On

Quoted 9 lines
Quoted 9 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 13 lines
Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

#8 lore raw
Quoted 71 lines · On 11/20/19 8:28 AM, Ivan Li11 wrote:
Quoted 71 lines

-----Original Message-----
From: Ivan Li11
Sent: Thursday, November 7, 2019 4:35 PM
To: 'James Feist' <[email protected]>; Matt Spinler <[email protected]>; [email protected]
Subject: RE: [External] Power-on monitor for phosphor-hwmon question

Quoted 7 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Thursday, November 7, 2019 7:39 AM
To: Ivan Li11 <[email protected]>; Matt Spinler <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 32 lines
Quoted 31 lines · On 11/5/19 11:25 PM, Ivan Li11 wrote:
Quoted 31 lines

-----Original Message-----
From: James Feist <[email protected]>
Sent: Tuesday, October 22, 2019 11:51 PM
To: Matt Spinler <[email protected]>; Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 13 lines · Matt Spinler
Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 7 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

It should force you to switch 100%, but you would at least have to run

both.

Quoted 23 lines
Quoted 4 lines
Quoted 4 lines

Here's what dbus-sensors does:

https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f6955827330

Quoted 11 lines
Quoted 8 lines

7
a59e4b1cf86b8a6/src/Utils.cpp#L141

Basically just a dbus-match that sets a "powerStatusOn" bool that can be queried. Depending on the sensor type thresholds don't get crossed if that bool is set. We also have a similar bool for bios post, as some sensors come up later after power on.

I try to use dbus-sensors and set "powerStatusOn" bool, but still have

incorrect threshold logs during power on(S0) to power off(S5) state.

Quoted 2 lines

Could you help to comment on it ?

This has only been tested with x86-power-control, are you using that project for power control or something else?

Quoted 5 lines
Quoted 1 line

Got it. I currently use phosphor-state-manager for power control.

Hi James,
It seems that x86-power-control need POWER_BUTTON and POWER_OUT to be connected to GPIOE0/E1 or GPIOE2/E3 for passthrough. If our HW design doesn't follow it, x86-power-control will not work, right ?

+ Jason, x86-power-control maintainer

I believe it just requires those names in the DTS, I don't think it cares what pins they are hooked to. Do you not have power buttons?

Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Thanks your great support in advance.

*From:*openbmc

<[email protected]>

Quoted 24 lines
Quoted 24 lines

*On

Quoted 9 lines
Quoted 9 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 13 lines
Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

author
#9 lore raw
In reply to Matt Spinler
Quoted 19 lines

-----Original Message-----
From: Matt Spinler <[email protected]>
Sent: Tuesday, October 22, 2019 9:24 PM
To: Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 7 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with entity-manager.

Hi Matt,
We can use dbus-match mechanism in phosphor-hwmon to turn on/off the thresholds just like what dbus-sensors repository does in the following link:
https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307a59e4b1cf86b8a6/src/Utils.cpp#L141

If it's ok for you, I'll work on it and send patch for you review. Please help to comment on it.

Quoted 25 lines
Quoted 3 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]>

*On

Quoted 8 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

author
#10 lore raw
In reply to Matt Spinler
Quoted 34 lines

-----Original Message-----
From: Ivan Li11
Sent: Wednesday, November 27, 2019 10:26 PM
To: 'Matt Spinler' <[email protected]>; [email protected]
Subject: RE: [External] Power-on monitor for phosphor-hwmon question

Quoted 19 lines

-----Original Message-----
From: Matt Spinler <[email protected]>
Sent: Tuesday, October 22, 2019 9:24 PM
To: Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 5 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 6 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with

entity-manager.

Quoted 1 line
Quoted 9 lines

Hi Matt,
We can use dbus-match mechanism in phosphor-hwmon to turn on/off the thresholds just like what dbus-sensors repository does in the following link:
https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307
a59e4b1cf86b8a6/src/Utils.cpp#L141

If it's ok for you, I'll work on it and send patch for you review. Please help to comment on it.

Hi Matt,
Could you help to comment on this proposal.
Thanks your great support in advance.

Quoted 25 lines
Quoted 25 lines
Quoted 3 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]>

*On

Quoted 8 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 12 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan

#11 lore raw
Quoted 37 lines · On 12/2/2019 9:15 AM, Ivan Li11 wrote:
Quoted 37 lines

-----Original Message-----
From: Ivan Li11
Sent: Wednesday, November 27, 2019 10:26 PM
To: 'Matt Spinler' <[email protected]>; [email protected]
Subject: RE: [External] Power-on monitor for phosphor-hwmon question

Quoted 18 lines

-----Original Message-----
From: Matt Spinler <[email protected]>
Sent: Tuesday, October 22, 2019 9:24 PM
To: Ivan Li11 <[email protected]>; [email protected]
Subject: Re: [External] Power-on monitor for phosphor-hwmon question

Quoted 4 lines · On 10/21/2019 6:02 AM, Ivan Li11 wrote:

Hi Team,

Does anyone have suggestion for this ?

Hi, you're right, it doesn't support that yet.  We've had a few internal discussions about how to handle that gracefully, though our platforms don't use sel-logger, but nothing solid came out of them and we don't have anything scheduled yet.

Quoted 6 lines

It would be easy enough to have a watch on the PGOOD property, and then do you what you want, like maybe turning off the thresholds.

I heard that the d-bus sensors repository has some sort of support for this, but since we don't use it I'm not sure what all that entails. I think it may also force you to replace phosphor-inventor-manager with

entity-manager.
Hi Matt,
We can use dbus-match mechanism in phosphor-hwmon to turn on/off the thresholds just like what dbus-sensors repository does in the following link:
https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307
a59e4b1cf86b8a6/src/Utils.cpp#L141

Quoted 6 lines
Quoted 3 lines

If it's ok for you, I'll work on it and send patch for you review. Please help to comment on it.

Hi Matt,
Could you help to comment on this proposal.
Thanks your great support in advance.

That sounds good to me.  Thanks!

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 4 lines

Thanks your great support in advance.

*From:*openbmc <[email protected]>

*On

Quoted 8 lines

Behalf Of *Ivan Li11
*Sent:* Friday, October 18, 2019 5:59 PM
*To:* [email protected]
*Subject:* [External] Power-on monitor for phosphor-hwmon question

Hi Team,

We found that there's no power-on monitor mechanism in

phosphor-hwmon.

Quoted 11 lines

https://github.com/openbmc/phosphor-hwmon

And it will cause incorrect threshold logs to be added to journal log by 'sel-logger' when system is in power off(S5) state.

Is there any plan to implement it? Or other repository we can refer to ?

Thanks,

Ivan